--- joko/Uni/BSArch/01/prime.c 2006/05/13 12:35:32 1.12 +++ joko/Uni/BSArch/01/prime.c 2006/05/15 11:25:40 1.15 @@ -1,10 +1,15 @@ -/* $Id: prime.c,v 1.12 2006/05/13 12:35:32 joko Exp $ */ +/* $Id: prime.c,v 1.15 2006/05/15 11:25:40 franky Exp $ */ #include #include +#include #include #include +#ifdef _MSC_VER +#define snprintf _snprintf +#endif + #define BOOL int #define TRUE 1 #define FALSE 0 @@ -19,13 +24,13 @@ /* check for prime number */ BOOL is_prime(long int number) { - int i; - + int i,sq; /* negative values, 0 and 1 are never prime numbers */ if (number < 2) return FALSE; + sq=sqrt(number); /* check all numbers 2..sqrt(number) for being a prime number */ - for (i=2; i*i <= number; i++) { + for (i=2; i <= sq; i++) { if ((number % i) == 0) return FALSE; } @@ -33,28 +38,37 @@ } /* convert from string to long int, with error checking */ -long int convert_number(const char *nptr) { +long int convert_number(const char *nptr, BOOL warn) { char * endptr; - long int number = strtol(nptr, &endptr, 10); - errno = 0; + long int number; + + number = strtol(nptr, &endptr, 10); /* invalid characters? */ if (*endptr != '\0') { - char message[254]; - snprintf(message, 256, "Could not convert '%s' to a valid (integer) number.", nptr); - PRINTERROR(message); - exit(EXIT_FAILURE); + char message[256]; + snprintf(message, 255, "Could not convert '%s' to a valid (integer) number.", nptr); + if(warn) + PRINTWARNING(message); + else{ + PRINTERROR(message); + exit(EXIT_FAILURE); + } } /* invalid range? */ /* if (number == LONG_MAX || number == LONG_MIN) { */ if (errno == ERANGE) { - char message[254]; - snprintf(message, 256, "Number is not in range of 'long int': %s", nptr); - PRINTERROR(message); - exit(EXIT_FAILURE); + char message[256]; + snprintf(message, 255, "Number is not in range of 'long int': %s", nptr); + if(warn) + PRINTWARNING(message); + else{ + PRINTERROR(message); + exit(EXIT_FAILURE); + } } return number; @@ -72,21 +86,25 @@ /* (3) range mode */ if (argc > 2) { long int i, j; - i = convert_number(argv[1]); - j = convert_number(argv[2]); + i = convert_number(argv[1],FALSE); + j = convert_number(argv[2],FALSE); for (i; i< j; i++) { PRINTPRIME(i); } /* other modes */ } else { - + int err; /* try to open file for reading */ FILE * fp = fopen(argv[1], "r"); - + err=errno; /* (1) test-single-number mode: first argument is not a filename */ if (fp == NULL) { - long int number = convert_number(argv[1]); + long int number = convert_number(argv[1],TRUE); + if(err){ + fprintf(stderr, "%s: %s\n", argv[1], strerror(err)); + return -1; + } PRINTPRIME(number); /* (2) file mode: read numbers from file */ @@ -129,7 +147,7 @@ } /* finally: prime number calculation and output */ - number = convert_number(line); + number = convert_number(line,FALSE); PRINTPRIME(number); }