--- nfo/perl/libs/Data/Transfer/Sync/StorageInterface.pm 2003/02/14 14:14:38 1.4 +++ nfo/perl/libs/Data/Transfer/Sync/StorageInterface.pm 2003/03/27 15:31:16 1.7 @@ -1,4 +1,4 @@ -## $Id: StorageInterface.pm,v 1.4 2003/02/14 14:14:38 joko Exp $ +## $Id: StorageInterface.pm,v 1.7 2003/03/27 15:31:16 joko Exp $ ## ## Copyright (c) 2002 Andreas Motl ## @@ -6,6 +6,15 @@ ## ## ---------------------------------------------------------------------------------------- ## $Log: StorageInterface.pm,v $ +## Revision 1.7 2003/03/27 15:31:16 joko +## fixes to modules regarding new namespace(s) below Data::Mungle::* +## +## Revision 1.6 2003/02/21 01:47:53 joko +## renamed core function +## +## Revision 1.5 2003/02/20 20:24:33 joko +## + additional pre-flight checks +## ## Revision 1.4 2003/02/14 14:14:38 joko ## + new code refactored here ## @@ -40,7 +49,7 @@ use Data::Dumper; use Hash::Merge qw( merge ); use libdb qw( hash2Sql ); -use Data::Transform::Deep qw( hash2object ); +use Data::Mungle::Transform::Deep qw( merge_to ); # get logger instance @@ -130,6 +139,17 @@ my $ident = shift; my $force = shift; +=pod + #print "isa: ", UNIVERSAL::isa($self->{meta}->{$descent}->{storage}), "\n"; + + # this seems to be the first time we access this side, + # so just check (again) for a valid storage handle + if (! ref $self->{meta}->{$descent}->{storage}) { + $logger->critical( __PACKAGE__ . "->_statloadNode( descent=$descent ident=$ident ): Storage handle undefined!" ); + return; + } +=cut + #$logger->debug( __PACKAGE__ . "->_statloadNode( descent=$descent ident=$ident )" ); # fetch entry to retrieve checksum from @@ -237,6 +257,13 @@ next; } + # 2.b check storage handle type + my $dbType = $self->{meta}->{$descent}->{storage}->{locator}->{type}; + if (!$dbType) { + $logger->critical( __PACKAGE__ . "->touchNodeSet: Storage ( descent='$descent', dbKey='$dbkey' ) has no 'dbType' - configuration-error?" ); + next; + } + # 3. check if descents (and nodes?) are actually available.... # TODO: # eventually pre-check mode of access-attempt (read/write) here to provide an "early-croak" if possible @@ -245,7 +272,6 @@ # print Dumper($self->{meta}->{$descent}->{storage}->{locator}); - my $dbType = $self->{meta}->{$descent}->{storage}->{locator}->{type}; my $nodeName = $self->{meta}->{$descent}->{nodeName}; my $accessorType = $self->{meta}->{$descent}->{accessorType}; my $accessorName = $self->{meta}->{$descent}->{accessorName}; @@ -451,7 +477,7 @@ # mix in (merge) values ... # TODO: use Hash::Merge here? benchmark! # no! we'd need a Object::Merge here! it's *...2object* - hash2object($object, $map); + merge_to($object, $map); # trace #print Dumper($object); @@ -483,7 +509,7 @@ # mix in values #print Dumper($object); # TODO: use Hash::Merge here??? - hash2object($object, $map); + merge_to($object, $map); #print Dumper($object); #exit;