--- nfo/perl/libs/Data/Transfer/Sync/StorageInterface.pm	2003/03/27 15:31:16	1.7
+++ nfo/perl/libs/Data/Transfer/Sync/StorageInterface.pm	2003/04/09 07:27:02	1.8
@@ -1,4 +1,4 @@
-##    $Id: StorageInterface.pm,v 1.7 2003/03/27 15:31:16 joko Exp $
+##    $Id: StorageInterface.pm,v 1.8 2003/04/09 07:27:02 joko Exp $
 ##
 ##    Copyright (c) 2002  Andreas Motl <andreas.motl@ilo.de>
 ##
@@ -6,6 +6,9 @@
 ##
 ##    ----------------------------------------------------------------------------------------
 ##    $Log: StorageInterface.pm,v $
+##    Revision 1.8  2003/04/09 07:27:02  joko
+##    minor update (just cosmetics)
+##
 ##    Revision 1.7  2003/03/27 15:31:16  joko
 ##    fixes to modules regarding new namespace(s) below Data::Mungle::*
 ##
@@ -48,7 +51,7 @@
 
 use Data::Dumper;
 use Hash::Merge qw( merge );
-use libdb qw( hash2Sql );
+use shortcuts::db qw( hash2sql );
 use Data::Mungle::Transform::Deep qw( merge_to );
 
 
@@ -180,10 +183,6 @@
       ]
     };
 
-    # trace
-      #print "query:", "\n";
-      #print Dumper($query);
-
     # send query and fetch first entry from result
       my $result = $self->{meta}->{$descent}->{storage}->sendQuery($query);
       my $entry = $result->getNextEntry();
@@ -356,10 +355,10 @@
       # TODO: wrap this around '$storageHandle->sendQuery(...)'!?
       my $sql_main;
       if (lc($action) eq 'insert') {
-        $sql_main = hash2Sql($self->{meta}->{$descent}->{accessorName}, $map, 'SQL_INSERT');
+        $sql_main = hash2sql($self->{meta}->{$descent}->{accessorName}, $map, 'SQL_INSERT');
       } elsif (lc $action eq 'update') {
         $crit ||= "$self->{meta}->{$descent}->{IdentProvider}->{arg}='$self->{node}->{$descent}->{ident}'";
-        $sql_main = hash2Sql($self->{meta}->{$descent}->{accessorName}, $map, 'SQL_UPDATE', $crit);
+        $sql_main = hash2sql($self->{meta}->{$descent}->{accessorName}, $map, 'SQL_UPDATE', $crit);
       }
       my $sqlHandle = $self->{meta}->{$descent}->{storage}->sendCommand($sql_main);
 
@@ -501,25 +500,20 @@
 
     } elsif (lc $action eq 'update') {
       
-      # get fresh object from orm first
+      # Get fresh object from orm first.
+      # TODO: Review, is a 'sendQuery' required in this place?
+      # By now: NO! It's more expensive and we can just expect existing objects for update operations.
+      # If it doesn't exist either, we assume the engine will fail on issuing the 'update' operation later...
       $object = $self->{meta}->{$descent}->{storage}->load($self->{node}->{$descent}->{ident});
 
-#print Dumper($self->{node});
-      
       # mix in values
-        #print Dumper($object);
-        # TODO: use Hash::Merge here???
-        merge_to($object, $map);
-        #print Dumper($object);
-        #exit;
+      merge_to($object, $map);
 
       # update orm
-        $self->{meta}->{$descent}->{storage}->update($object);
+      $self->{meta}->{$descent}->{storage}->update($object);
         
     }
 
-#exit;
-    
     my $error = 0;
 
     # handle new style callbacks - this is a HACK - do this without an eval!