--- nfo/perl/libs/DesignPattern/Object.pm 2003/02/11 11:04:27 1.6 +++ nfo/perl/libs/DesignPattern/Object.pm 2003/02/18 18:34:35 1.7 @@ -1,7 +1,10 @@ ## --------------------------------------------------------------------------- -## $Id: Object.pm,v 1.6 2003/02/11 11:04:27 joko Exp $ +## $Id: Object.pm,v 1.7 2003/02/18 18:34:35 joko Exp $ ## --------------------------------------------------------------------------- ## $Log: Object.pm,v $ +## Revision 1.7 2003/02/18 18:34:35 joko +## + fix: just logs if possible (sub log_basic) +## ## Revision 1.6 2003/02/11 11:04:27 joko ## + metadata (args, caller, etc.) are now stored inside {__bridge} ## @@ -34,8 +37,12 @@ #use Devel::StackTrace; -# get logger instance -my $logger = eval { Log::Dispatch::Config->instance; }; +my $_dp_globals; + +$_dp_globals = { + TRACE => 0, +}; + sub new { @@ -45,7 +52,7 @@ # use already blessed reference, if passed in - else use the very classname my $class = ref ($classname) || $classname; - $logger->debug( "$classname->new( ... )" . "\t[via " . __PACKAGE__ . "]" ) if $logger; + #$self->log_basic( "$classname->new( ... )" . "\t[via " . __PACKAGE__ . "]" , 'debug'); # the base for our object - a plain perl hash, which .... my $self = {}; @@ -60,7 +67,7 @@ # TODO: what about logging in here? inherit from # DesignPattern::Object::Logger for this purpose.... # ... or would this give us (harmful) circular module dependencies??? - #$logger->debug( __PACKAGE__ . "->new( @args )" ); # this is not "common"! + #$self->log_basic( __PACKAGE__ . "->new( @args )", 'debug' ); # this is not "common"! # remember the stacktrace: abstract this out (DesignPattern::Object::Trace) or parametrize! @@ -130,7 +137,7 @@ my $self_classname = ref $self; my $function_name = shift; # was: - $logger->warning( __PACKAGE__ . ": function '$function_name' is an abstract method, please implement it in '$self_classname'."); + $self->log_basic( __PACKAGE__ . ": function '$function_name' is an abstract method, please implement it in '$self_classname'.", 'warning'); # is: #die( __PACKAGE__ . ": Function '$function_name' is an abstract method, please implement it in '$self_classname'."); #exit; @@ -147,7 +154,7 @@ #print Dumper($args); - $logger->debug( __PACKAGE__ . "->fromPackage( pkgname $pkgname args @args )" ); + $self->log_basic( __PACKAGE__ . "->fromPackage( pkgname $pkgname args @args )", 'debug'); # perl-load my $evstring = "use $pkgname;"; @@ -160,13 +167,13 @@ #my $classname = $self->{__classname}; my $errmsg_critical = ''; if ($errmsg_native =~ m/Can't locate (.+?) in \@INC/) { - $errmsg_critical = "Could not instantiate object from package '$pkgname' - location of '$1' failed."; + $errmsg_critical = "Could not instantiate object from package '$pkgname' ('$1' not found)."; } else { $errmsg_critical = $errmsg_native; } # write error to logging-output (console|file|database) - $logger->debug( $errmsg_native ); - $logger->critical( $errmsg_critical ); + $self->log_basic( $errmsg_native, 'debug' ); + $self->log_basic( $errmsg_critical, 'warning' ); return; } @@ -180,4 +187,27 @@ return $object; } +sub log_basic { + my $self = shift; + my $message = shift; + my $level = shift; + + if ($_dp_globals->{TRACE} || ($level && $level =~ /warning|error|critical/)) { + print $level, ": ", $message, "\n"; + } + + # get logger instance + if (!$_dp_globals->{logger}) { + $_dp_globals->{logger} = eval { Log::Dispatch::Config->instance; }; + } + + if ($_dp_globals->{logger}) { + $_dp_globals->{logger}->log($level, $message); + #} else { + #print $level, ": ", $message, "\n"; + } + +} + 1; +__END__